Allow Window's focus() API to focus opener #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1. Let |pipWindow| be |current|'s <a>active window</a>'s | ||
| <a>documentPictureInPicture API</a>'s <a>last-opened window</a>. | ||
| 2. If |pipWindow| is not <code>null</code> and |pipWindow|'s <a>relevant global object</a> | ||
| has <a>transient activation</a>, then: |
There was a problem hiding this comment.
It would be nice to raise an Exception to inform developer focus() requires a user gesture from a PiP window.
There was a problem hiding this comment.
The problem is that focus() is still technically usable regardless, you just wouldn't get system-level focus in this case. It would essentially mean any time a window that owns a pip window calls window.focus() (or another window calls focus() on it), they'd get a new error despite otherwise having the same functionality as before
This was referenced Jan 31, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows websites to use
opener.focus()to give focus to the opener tab from the picture-in-picture window.Fixes #94