Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-stage docker build for dev and production #2

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Multi-stage docker build for dev and production #2

merged 1 commit into from
Jun 9, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jun 6, 2022

Multi-stage docker builds

  • uses docker --target to build images:
    • dev
      • Barebones dependencies
      • No code incuded in image
      • live mounted on run
    • production
      • Based on dev
      • Application code included in image

@mrharpo mrharpo requested a review from foglabs June 6, 2022 22:01
@mrharpo mrharpo self-assigned this Jun 7, 2022
afred
afred approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 43782d8 into main Jun 9, 2022
@afred afred deleted the docker-multi-stage branch June 9, 2022 18:33
@mrharpo mrharpo added the enhancement ➕ New feature or request label Jun 10, 2022
@mrharpo mrharpo added enhancement ➕ New feature or request and removed enhancement ➕ New feature or request labels Jul 5, 2022
@mrharpo mrharpo added this to the v0.1.0 Demo 🏗️ milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

@foglabs foglabs Awaiting requested review from foglabs

Assignees

@mrharpo mrharpo

Labels
enhancement ➕ New feature or request
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.1.0 Demo 🏗️
Development

Successfully merging this pull request may close these issues.
2 participants
@mrharpo @afred