$SqlConnection.Close() not in a finally block

[rancourt-martin]

Hi,
(amazing piece of code that saved me weeks of back and forth with a client)
fyi, I ran into the case where after completion of psblitz, connection is not closed and lingers on the sqlserver. we suspect this is caused by the $SqlConnection.Close() (or dispose) not being in a "finally" block.

[VladDBA]

Hi @rancourt-martin ,
Thank you for the feedback!
I'm glad you find it useful.
I'll address this bug in the next release.

[VladDBA]

Hi Martin,
I've added another pair of $SqlConnection.Close() and $SqlConnection.Dispose() (there already is a $SqlConnection.Dispose() at the begging of the finally block), but the connection still remains after PSBlitz execution finishes.
The good news is that closing the PowerShell window from which PSBlitz was executed causes the leftover connection to close immediately. If the PS window is left open the leftover connection disappears from SQL Server within 3 minutes, at least from what I've tested.

[rancourt-martin]

Good stuff, Really appreciate the feedback Martin

…

__________ Martin Rancourt 514.567.1297 Le 10 nov. 2023 à 17:58, Vlad Drumea ***@***.***> a écrit :  I've added another pair of $SqlConnection.Close() and $SqlConnection.Dispose() (there already is a $SqlConnection.Dispose() at the begging of the finally block), but the connection still remains after script PSBlitz execution finishes. The good news is that closing the PowerShell window from which PSBlitz was executed causes the leftover connection to close immediately — Reply to this email directly, view it on GitHub<#124 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AONZ7WOY2DNDONBB4ZEIZFDYD2WQHAVCNFSM6AAAAAA6YC3PS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGUZTQMJTGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>