Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Internet Explorer polyfills #20

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Conversation

piboistudios
Copy link
Contributor

@piboistudios piboistudios commented Jan 24, 2019

IE9+ Compatibility

@nikolasp
Copy link
Collaborator

Hi @piboistudios,

Thanks for the pull request.
I don't think that we should pack polyfills with the library. It's always better to do that on application level, especially today when almost everything is bundled (webpack, parcel, rollup, etc).
However, maybe we can pack polyfills but say to users that they will have to import additional js file if they want to support IE and that will be stated in README. What do you think about this?

I share the same thoughts as @sokra when it comes to polyfills.
Take a look at w3ctag/polyfills#6 (comment)

@piboistudios
Copy link
Contributor Author

That's a good point.

Maybe include it as a part of the README.md in an added Browser Compatibility section?

@nikolasp
Copy link
Collaborator

Sure, I'll do that. I think that we can accept your pull request, just before that we need to remove
import './polyfills'; from src/index.js and then in README we can point out this file for IE support.

@nikolasp
Copy link
Collaborator

Thanks @piboistudios, 🎉

I'll add you to the list of contributors.

@nikolasp nikolasp merged commit a3ae687 into Vivify-Ideas:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants