Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(converters): add unit tests for converters #97

Merged
merged 1 commit into from
Sep 13, 2024
Merged

tests(converters): add unit tests for converters #97

merged 1 commit into from
Sep 13, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Sep 6, 2024 •
edited
Loading

Motivation and Context

I'd like to refactor converters, but first need unit tests to ensure changes don't break existing components.

Changes

  • Add unit tests for all converters that have datasets associated with them (this is a best effort attempt)

Testing

  • All new unit tests pass

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999 tonywu1999 merged commit 0c94374 into devel Sep 13, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the converter-tests branch September 13, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devonjkohler devonjkohler Awaiting requested review from devonjkohler

@mstaniak mstaniak Awaiting requested review from mstaniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tonywu1999