Improve performance in big repos by adding files to stage explicitly #84
Conversation
There was a problem hiding this comment.
I really love this change! Thank you so much for suggesting it.
I did a little research just to understand why this is faster and if it scales and it looks like this is actually the preferable implementation for even a large number of file changes.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=494323#c8
It looks like I missed reimplementing this when downgrading jgit for wider device support
https://github.com/ViscousPot/GitSync/pull/44/files#diff-248e46999edf160924fa7c9cace3d1c78ae69996d2980ef9e2b94c8f15f0c918L225
Let me know if you disagree with this being fine for more file changes, but otherwise, could you remove the gating behind the MAX_FILES_TO_STAGE_EXPLICITLY constant and I'd be happy to get this merged :)
|
Done, I also think it is cleaner that way |
In my big repo (>1 GB), it took several minutes to run "git add ." even on a one-line change.
With this fix, it works much faster and makes GitSync usable for me.