-
Notifications
You must be signed in to change notification settings - Fork 447
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🗿 Rock-conaissance, also break config
The existing `ViewComponent::Config` object seems fit for purpose when it comes to component-local config, but I think what we want is: - a `RailsAppConfig` object that's responsible for the things that will still need to be set against `Rails.application.config` - a `ComponentLocalConfig` object that's effectively `ViewComponent::Config`. We should make sure that config is inheritable, and perhaps provide some kind of DSL to set it up, e.g.: ```rb class ApplicationComponent < ViewComponent::Base configure do some_option true some_other_option "value" end end ```
- Loading branch information
Showing
8 changed files
with
189 additions
and
220 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.