You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @dmitryk-dk could you please elaborate more on what this PR does? What was the reason of errors and how it was addressed?
We run onRunQuery function which is used for the Explore tab, and in that case for the /api/v1/eval grafana missed the query for the A expression. The request body presents only B and C conditions, but Grafana awaits requests with A conditions. And that behavior produces the issue. Also, there was a problem with render, which started to make infinite requests to the /api/v1/eval API.
In another case, we made two requests when using query search field, so this behavior was prevented too.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed behavior of the query editor which produces a bug for alerting rule evaluation
Related issue: #134
Signed-off-by: dmitryk-dk d.kozlov@victoriametrics.com