Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a warning for WITH templates in uncreated dashboards #124

Merged
merged 1 commit into from
Dec 18, 2023
Merged

add a warning for WITH templates in uncreated dashboards #124

merged 1 commit into from
Dec 18, 2023

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Dec 15, 2023

  • add a warning window about using WITH templates for not yet created dashboards. See this issue.
  • add a separate scope for storing WITH templates for the Explore tab.
Screenshot 2023-12-15 at 14 52 14

dmitryk-dk
dmitryk-dk approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hagen1778
hagen1778 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hagen1778 hagen1778 merged commit 6c9b726 into main Dec 18, 2023
4 checks passed
@hagen1778 hagen1778 deleted the issue-123/fix-template-saving branch December 18, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagen1778 hagen1778 hagen1778 approved these changes

@dmitryk-dk dmitryk-dk dmitryk-dk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Loori-R @hagen1778 @dmitryk-dk