Skip to content

Commit

Permalink
Fix issue with lezer-metricsql dependency and public folder (#256)
Browse files Browse the repository at this point in the history
update CHANGELOG.md
  • Loading branch information
dmitryk-dk authored Jan 23, 2025
1 parent f46ae05 commit 81039d0
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## tip

* BUGFIX: fix issue with including the lezer-metricsql package to the build and fix public folder. See [this PR](https://github.com/VictoriaMetrics/victoriametrics-datasource/pull/256).

## v0.12.0

⚠️ **Breaking Change: Plugin ID Updated**
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ frontend-build: frontend-package-base-image
--user $(shell id -u):$(shell id -g) \
--env YARN_CACHE_FOLDER="/victoriametrics-datasource/.cache" \
--entrypoint=/bin/bash \
frontent-builder-image -c "yarn install --omit=dev && yarn build"
frontent-builder-image -c "yarn preinstall && yarn install --omit=dev && yarn build"

app-via-docker-local:
$(eval OS := $(shell docker run $(GO_BUILDER_IMAGE) go env GOOS))
Expand Down
2 changes: 1 addition & 1 deletion packages/lezer-metricsql/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "lezer-metricsql",
"version": "0.1.4",
"version": "0.1.5",
"main": "index.cjs",
"type": "module",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const config = (env) => {
path: path.resolve(__dirname, 'plugins/victoriametrics-metrics-datasource'),
filename: '[name].js',
// Keep publicPath relative for host.com/grafana/ deployments
publicPath: '/public/plugins/plugins/victoriametrics-metrics-datasource/',
publicPath: '/public/plugins/victoriametrics-metrics-datasource/',
},
resolve: {
alias: {
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7101,7 +7101,7 @@ levn@^0.4.1:
type-check "~0.4.0"

"lezer-metricsql@file:packages/lezer-metricsql":
version "0.1.4"
version "0.1.5"

lines-and-columns@^1.1.6:
version "1.2.4"
Expand Down

0 comments on commit 81039d0

Please sign in to comment.