Add toggle for bubble pop sound/icons #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think its a good idea to remove useful and functional game features. Else ViaFabricPlus would also have to revert the potion HUD overlay |
|
Thats why its a toggle |
|
Also the bubble sound is annoying to some |
|
Yall hide hunger/xp for <=b1.7.3 & other stuff |
because those don't work. the air bubbles do work tho |
Your current implementation would disable the sound/empty bubble icon by default when using older versions, which isn't good |
|
then ill change that |
|
Fixed |
RaphiMC
approved these changes
Dec 7, 2024
FlorianMichael
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 toggles for <=1.21.1 to remove the annoying bubble pop sound/visual