Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizations of full_str_int #118

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Optimizations of full_str_int #118

merged 12 commits into from
Feb 21, 2024

Conversation

vhavlena
Copy link
Collaborator

@vhavlena vhavlena commented Feb 11, 2024 •
edited
Loading

This PR contains:

  • special axiom instantiation
  • new preprocessing rules

@vhavlena vhavlena changed the title preprocess: common suffix propagation Optimizations of full_str_int Feb 12, 2024
@vhavlena
Copy link
Collaborator Author

On full_str_int:

# of formulae: 16968
###################################################################################
####                                   Table 1                                 ####
###################################################################################
| method                     |    max |      mean |   median |   std. dev |   TO+MO+ERR |   unknowns |
|----------------------------|--------|-----------|----------|------------|-------------|------------|
| z3-noodler-bdb7f83-2cddb2f |  84.32 | 0.225197  |     0.01 |   1.77001  |         715 |        895 |
| cvc5-1.0.8                 |  82.08 | 0.309905  |     0.03 |   1.18924  |           0 |          0 |
| z3-4.12.2                  | 118.32 | 1.44806   |     0.04 |   7.81162  |         234 |          0 |
| z3-noodler-1174fd1-2cddb2f |  96.78 | 0.130747  |     0.01 |   1.59691  |        1212 |       1199 |

@vhavlena vhavlena marked this pull request as ready for review February 17, 2024 07:38
@vhavlena vhavlena requested review from jurajsic and Adda0 February 17, 2024 07:38
Adda0
Adda0 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me at a quick glance.

jurajsic
jurajsic approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some random questions

@vhavlena
Copy link
Collaborator Author

Can I merge it?

@jurajsic
Copy link
Member

You can merge it.

@vhavlena vhavlena merged commit 5325c2a into devel Feb 21, 2024
@vhavlena vhavlena deleted the full-int-opt branch February 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajsic jurajsic jurajsic approved these changes

@Adda0 Adda0 Adda0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhavlena @jurajsic @Adda0