An optimisation of underapproximation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results on all benchmarks. On
|
jurajsic
approved these changes
Jan 8, 2024
Comment on lines
1386
to
1390
| mata::OnTheFlyAlphabet mata_alphabet{}; | ||
| for (const auto& symbol : alphabet) { | ||
| mata_alphabet.add_new_symbol(std::to_string(symbol), symbol); | ||
| } | ||
| mata::nfa::Nfa aut_compl = mata::nfa::complement(*(this->aut_ass.at(var)), mata_alphabet); |
There was a problem hiding this comment.
We should really make this a method of AutAssignment, I think I wrote such code multiple times already, and it is even used twice in this pull request.
There was a problem hiding this comment.
Looking at it more properly, the complement of NFA for var is computed twice here, once in is_co_finite and again here, can we reuse it somehow?
There was a problem hiding this comment.
- good point. Should be fixed now
- true, but I don't want to make a side effect in
is_co_finite.
Adda0
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor change of co-finite check to allow a wider range of constraint to pass the underapproximation.