Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizations for hard equations #103

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Optimizations for hard equations #103

merged 8 commits into from
Nov 24, 2023

Conversation

vhavlena
Copy link
Collaborator

@vhavlena vhavlena commented Oct 18, 2023 •
edited
Loading

Optimizations for hard equations

  • extending Nielsen transformation to handle general equations (no termination guarantee though)
  • length-based pruning of the proof graph
  • both side trimming of the nodes
  • various other fixes

@vhavlena vhavlena requested review from jurajsic and Adda0 November 16, 2023 13:15
@vhavlena
Copy link
Collaborator Author

@jurajsic Before merging, could you please check if the Kepler benchmark is ok? I made some changes that could possibly affect this benchmark.

@jurajsic
Copy link
Member

image
image
On woorpje we still have 80 TO/MEMOUT (see attached .txt), but much better than 1.0.0, which had 243. On Kepler we have 3 TO, which is 1 less.
message.txt
message(1).txt

@vhavlena
Copy link
Collaborator Author

Thanks a lot! The results look nice. We can get back and try to solve the remaining 80 TOs at some point.

Adda0
Adda0 reviewed Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me overall. I will approve later when I check a few more parts more thoroughly.

src/smt/theory_str_noodler/nielsen_decision_procedure.h Outdated
Comment on lines 291 to 293
* @return false -> unsatisfiable
*/
static bool is_length_unsat(const Predicate& pred);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_length_usnat() returns false for unsat result? That is confusing. It should either be named is_length_sat(), or keep the name and return true if unsat.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I fixed the comment.

jurajsic
jurajsic approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I can't say I fully understand it though.

@vhavlena
Copy link
Collaborator Author

@Adda0 Can you finish your review? I would like to merge it to move on.

Adda0
Adda0 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the rest of the changes. LGTM.

@vhavlena
Copy link
Collaborator Author

Great, I merge it today.

@vhavlena vhavlena merged commit 622f1ed into devel Nov 24, 2023
@vhavlena vhavlena deleted the hard-eqs-opt branch November 24, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajsic jurajsic jurajsic approved these changes

@Adda0 Adda0 Adda0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhavlena @jurajsic @Adda0