Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vote proposal card UI #561

Merged
merged 7 commits into from
Jun 1, 2022
Merged

Add vote proposal card UI #561

merged 7 commits into from
Jun 1, 2022

Conversation

baomastr
Copy link
Contributor

@baomastr baomastr self-assigned this May 27, 2022
@reg-suit
Copy link

reg-suit bot commented May 27, 2022 •
edited
Loading

reg-suit detected visual differences.

Check this report, and review them.

⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@baomastr baomastr force-pushed the feature/vote-proposal-component branch from b45af28 to 235757a Compare May 30, 2022 14:26
@baomastr baomastr marked this pull request as ready for review May 31, 2022 10:20
@baomastr baomastr requested review from coreyar and therealemjy May 31, 2022 10:20
@baomastr baomastr force-pushed the feature/vote-proposal-component branch from c01e579 to 2748bd3 Compare May 31, 2022 10:38
@baomastr
Copy link
Contributor Author

ready for the review except for one thing: https://ankr.slack.com/archives/C036GDU0YCW/p1653991624611809

@baomastr baomastr requested a review from coreyar June 1, 2022 14:20
@therealemjy
Copy link
Member

Desktop view looks good, just one small thing: the div containing the labels in the top left corner as well as the voting status of the user for that proposal in the top right corner needs to be given the css prop align-items: center so that these elements are vertically aligned.

On the mobile view, there's one issue with the vote progress bars:
Screen Shot 2022-06-01 at 1 27 57 PM

@baomastr baomastr force-pushed the feature/vote-proposal-component branch from 1183040 to 9f20a28 Compare June 1, 2022 16:17
@coreyar coreyar force-pushed the feature/vote-proposal-component branch from 9f20a28 to 68281e7 Compare June 1, 2022 20:19
@coreyar coreyar self-requested a review June 1, 2022 21:35
@coreyar coreyar merged commit 424c265 into develop Jun 1, 2022
@coreyar coreyar deleted the feature/vote-proposal-component branch June 2, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyar coreyar coreyar approved these changes

@therealemjy therealemjy Awaiting requested review from therealemjy

Assignees

@baomastr baomastr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baomastr @therealemjy @coreyar