-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use address from npm packages #108
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4868b8a
refactor: use address from npm packages
coreyar ee33b50
refactor: merge docker json files
coreyar cb18119
fix: update name of ReservesReduced event
coreyar 944eade
fix: update compiler version to support 0.8.20
coreyar 64934aa
refactor: remove bnb address from configs
coreyar af9426e
test: update test fixtures
coreyar bd0ddf2
test: set deployer as timelock admin
coreyar 23c345f
test: update governance tests
coreyar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import configureFeeds from '@venusprotocol/oracle/dist/deploy/2-configure-feeds'; | ||
import configureFeeds from '@venusprotocol/oracle/dist/deploy/3-configure-feeds'; | ||
|
||
export default configureFeeds; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 0 additions & 133 deletions
133
patches/@venusprotocol+governance-contracts+1.3.0.patch
This file was deleted.
Oops, something went wrong.
30 changes: 30 additions & 0 deletions
30
patches/@venusprotocol+governance-contracts+1.4.0-dev.9.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
diff --git a/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha.sol b/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha.sol | ||
index fca5350..4713034 100644 | ||
--- a/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha.sol | ||
+++ b/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha.sol | ||
@@ -27,8 +27,8 @@ contract GovernorAlpha { | ||
|
||
/// @notice The duration of voting on a proposal, in blocks | ||
function votingPeriod() public pure returns (uint) { | ||
- return (60 * 60 * 24 * 3) / 3; | ||
- } // ~3 days in blocks (assuming 3s blocks) | ||
+ return 100; | ||
+ } // A reasonable amount of block suitable for testing | ||
|
||
/// @notice The address of the Venus Protocol Timelock | ||
TimelockInterface public timelock; | ||
diff --git a/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha2.sol b/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha2.sol | ||
index c009718..0e8e8ec 100644 | ||
--- a/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha2.sol | ||
+++ b/node_modules/@venusprotocol/governance-contracts/contracts/legacy/GovernorAlpha2.sol | ||
@@ -27,8 +27,8 @@ contract GovernorAlpha2 { | ||
|
||
/// @notice The duration of voting on a proposal, in blocks | ||
function votingPeriod() public pure returns (uint) { | ||
- return (60 * 60 * 24 * 3) / 3; | ||
- } // ~3 days in blocks (assuming 3s blocks) | ||
+ return 100; | ||
+ } // A reasonable amount of block suitable for testing | ||
|
||
/// @notice The address of the Venus Protocol Timelock | ||
TimelockInterface public timelock; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking if these Test contracts are something you want to keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need this because the regular timelock delays are too long. This allows us to customize them