Skip to content

Commit

Permalink
Merge pull request #143 from Venafi/ruamel-upgrade
Browse files Browse the repository at this point in the history
fix(ruamel): upgrades ruamel version on setup.py to 0.18.5
  • Loading branch information
rvelaVenafi authored Feb 7, 2024
2 parents c5b198d + 41fd6a7 commit e7cb2c6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 2 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
url="https://github.com/Venafi/vcert-python",
packages=['vcert', 'vcert.parser', 'vcert.policy'],
install_requires=['requests==2.31.0', 'python-dateutil==2.8.2', 'certvalidator<=0.11.1', 'six==1.16.0',
'cryptography==42.0.2', 'ruamel.yaml==0.17.31', 'pynacl==1.5.0'],
'cryptography==42.0.2', 'ruamel.yaml==0.18.5', 'pynacl==1.5.0'],
description='Python client library for Venafi Trust Protection Platform and Venafi Cloud.',
long_description=long_description,
long_description_content_type="text/markdown",
Expand All @@ -27,5 +27,4 @@
'Programming Language :: Python :: 3.10',
'Operating System :: OS Independent',
"License :: OSI Approved :: Apache Software License",
])

])
4 changes: 4 additions & 0 deletions vcert/connection_tpp_abstract.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,17 +331,21 @@ def renew_cert(self, request, reuse_key=False):
def revoke_cert(self, request):
if not (request.id or request.thumbprint):
raise ClientBadData

d = {
'Disable': request.disable
}
if request.reason:
d['Reason'] = request.reason
if request.comments:
d['Comments'] = request.comments
if request.id:
d['CertificateDN'] = request.id
elif request.thumbprint:
d['Thumbprint'] = request.thumbprint
else:
raise ClientBadData

# TODO: Change _post() with post(args)
status, data = self._post(URLS.CERTIFICATE_REVOKE, data=d)
if status in (HTTPStatus.OK, HTTPStatus.ACCEPTED):
Expand Down

0 comments on commit e7cb2c6

Please sign in to comment.