Patt MacMillan - Velir Programming Test #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue where link to the Feedback page was not working. Fixed issue where /Feedback route would fail (Index ActionResult). Fixed issue where ThankYou page would not properly display form data and subsequently would crash. Fixed isse where the Email field on the Feedback form had inconsistent requirements. Fixed issue where validation messages on Feedback form were not displaying correctly. Fixed issue where site errors were not routed to the custom Error page. Added new NotFound page to exist alongside the Error page for 404 errors. Added Applicaiton_Error function to Global.asax to better handle error and not found pages. Added new utility for determining a page's indexable status. Additionally added robots metadata into the <head>. Adjusted BundleConfig.cs to include custom javascript.
Added form error message when all fields are not properly filled out. Adjuste NotFound and Error pages to contain status codes and updated language. Removed unused code and files from solution, removed links to unused pages. Adjusted fonts, styling and other front end considerations. Added instructions, bugfixes and other changes in text format on the homepage. Various other adjustments.
…ck to fix an issue with form validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
Here is my Pull Request for the Velir Programming Test. On the homepage you will find a list of changes made, both listed and unlisted bugfixes and some enhancements as well.
This was tested on the latest versions of Chrome, Edge and Firefox at desktop, tablet and mobile sizes.
I'm looking forward to reviewing this together with your team!