Using Default Language to look up base templates.

[kmazzoni]

When using the GlassInterfaceFactory in a non-default language, not all properties were getting mapped properly. This was because the Base Template lookup was using the current language instead of the Default language.

[smithc]

Hey Kevin,

I've added a change to your PR to use Glass' VersionCountDisabler instead of explicitly resolving the glass items in the 'default' language.

The core issue you discovered looks to arise when an item being requested does not have a version in the current language context. While your change probably works in most cases, I don't think we can necessarily rely on all items having versions in the default language.

My change to use the VersionCountDisabler should ensure that we are returned a version of the item with the Shared fields populated - and this should include the 'Template' and '__Base tempaltes' fields.

You may want to check the change out, and verify my assumptions, but I'm hopeful this should solve the issue.

Thanks!
Chris

[kmazzoni]

Hey Chris,

I think for this specific situation we are looking up templates which will likely always have a version in the default language, I suspect. However, if this a more fail-safe approach I'm all for it. The fix appears to work from my testing. I just checked in a minor change to reduce a little bit of nesting.

Thanks,

Kevin