Refactoring Jabberwocky.Glass.Autofac.Mvc into two separate projects. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. However, regarding versioning strategy, these are considered breaking changes. Do you see any reason that we can't rev to v2 for Jabberwocky.Glass.Autofac.Mvc? Otherwise, we can forward the types, and deprecate the old versions of classes being moved and just do a minor release. |
|
I agree these would be breaking changes but I guess, as I think about it, it's probably appropriate to try take the steps to allow for a minor revision rather than a major revision. I can look into updating this pull request to include type-forwarding, etc. |
Created Jabberwocky.Glass.Mvc and Jabberwocky.Glass.Mvc.Tests projects. Moved, MVC code with no Autofac dependencies to new projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Jabberwocky.Glass.Mvc and Jabberwocky.Glass.Mvc.Tests projects.
Moved, MVC code with no Autofac dependencies to new projects.
Having a project without Autofac dependencies could be pretty useful. Particulary in the Reusable Component Library.