Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataloader sampler configs and instantiation #7

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update dataloader sampler configs and instantiation #7

merged 1 commit into from
Sep 4, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Sep 4, 2024

PR Type

Fix

Short Description

  • Only add samplers from PyTorch that have data_source or dataset as the first argument.
  • Fix sampler instantiate method to match.

Tests Added

...

@fcogidi fcogidi added bug Something isn't working refactor Change exisiting code while maintaining the same functionality labels Sep 4, 2024
@fcogidi fcogidi merged commit 1ce1652 into main Sep 4, 2024
4 checks passed
@fcogidi fcogidi deleted the fco/fix_sampler_instantiation branch September 4, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working refactor Change exisiting code while maintaining the same functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fcogidi