-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base box for VMWare #881
Update base box for VMWare #881
Conversation
- make code more standard and readable - define variables within functions as local Shell is special, even variables declared inside a function and inside another block, appearing to have limited scope, will still be available after the function call. Define as local to avoid potential issues. - insert space around code inside $(( ... ))
…agrants#905) * Update README.md Create an anchor to important heading * Update README.md * Update README.md Credentials at a glance * Update README.md * Update README.md * Update README.md * Update README.md Table of content and anchor links to the most important topics * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
Makes it about a gazillion times faster.
Now that these are available in the path, use them in provisioning as well.
…Vagrants/pr/878 [PR] Link `phpcbf` and `phpcs` to `/usr/local/bin`
Thanks for the PR @khromov! I'm more than happy to merge this in, though I haven't used the VMWare configuration at all myself. I'd like to get a +1 if possible from others using VMWare. My only concern is that a box change is probably considered breaking in that someone would need to back-up all of their work before provisioning. |
fix some ShellCheck code linter warnings
…Vagrant-Vagrants#806) * Add names to provisioners so they can be called individually * Shorten provisioner names * Normalize provisioner path parameter
…ng-Vagrant-Vagrants#863) * Adjust heading for Bug fixes and enhancements * Add nvm
* Update contributors list * Add goblindegook as a contributor * Additional contributor updates * Update with more contributors * Update README.md Added recommendation to run cmd window as Administrator, this was causing me an issue when trying to write to the hosts file * Add another contributor * And update more contributors
…nal plugin steps (Varying-Vagrant-Vagrants#875) * Note `vagrant-vbguest` plugin in the README, as per discussion in Varying-Vagrant-Vagrants#800. * Group the optional plugin installation steps for ease of reading.
…nts#925) not under [mysql]. the current way is throwing errors on provision
… change-base-box
This PR needs rebasing |
Ok, it looks like the next version of VVV is going to be best with a full destroy and provision, so it would be the right time to update the box if necessary. Both the current box and the new box have about 10,000 downloads through https://atlas.hashicorp.com/boxes/. There are a few others that have hundreds of thousands of downloads. Is it possible that another box is the right answer for the long term? https://atlas.hashicorp.com/geerlingguy/boxes/ubuntu1404 looks like it may have some promise. I'm not opposed to using the suggested box, but I want to make sure we're getting this right for the next couple years. Also - we may need a new PR that just replaces the box name. I can cherry-pick if needed, but a clean PR would be helpful. |
Sounds good to me 👍 What about https://atlas.hashicorp.com/geerlingguy/boxes/ubuntu1604 ? |
I'm going to close this PR and defer to #1074 as the new issue for tracking the state of this. I think we need a new PR that uses the geerlingguy box and is based against a more recent version of the |
This PR changes the base box for VMWare Fusion / Workstation.
The old box has not been updated for 2 years and has some very old packages. The new box was updated more recently (currently with 14.04.3 about 9 months ago).
I also found the old box had some problems with HGFS (shared folder) initiation that would cause it to hang on provision intermittently (Related issue: hashicorp/vagrant#6775 )
The VVV provisioning was tested and successful on the new box.