Update connectivity_util.dart #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling "http://www.gstatic.com/generate_204" instead of "google.com" might be more faster and better since google.com returns response body which will take some time also it costs more mobile data. PS: `generate_204` is used for detecting internet connectivity in android, also used for prefetching DNS on chrome, google search and other google products.
lucalves
suggested changes
Apr 29, 2020
|
The curl request runs successfully.
|
Vanethos
approved these changes
May 17, 2020
| @@ -90,7 +90,7 @@ class ConnectivityUtils { | |||
|
|
|||
| // ignore: close_sinks | |||
| final result = await http.get(_serverToPing); | |||
| if (result.statusCode == 200 && _callback(result.body)) { | |||
| if (result.statusCode > 199 && result.statusCode < 400 && _callback(result.body)) { | |||
There was a problem hiding this comment.
Thanks for this, since custom servers might return results other than 200!
|
Thanks for the PR! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling "http://www.gstatic.com/generate_204" instead of "google.com" might be more faster and better since google.com returns response body which will take some time also it costs more mobile data.
PS:
generate_204is used for detecting internet connectivity in android, also used for prefetching DNS on chrome, google search and other google products.