Fix debugger and journal bugs #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Vandesm14
commented
Jun 24, 2024
•
- Index out of bounds on swap ops
- Ensure that we set last_index after we reload
- Memory leak on slider change or reload
- Removed the journal output, fixed for now, lol
- Journal only reports the latest value for scopes
- Implemented op-based scope mutations so they can be stored within the ops (saving on some memory)
df20694 to
b33b658
Compare
|
@leonskidev Can you test this with the bugs you found to ensure that these are fixed? |
leonskidev
approved these changes
Jun 30, 2024
c983e25 to
680a5cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.