Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force ArgoCD to replace Jobs when syncing #481

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

tijmenstor
Copy link
Contributor

@tijmenstor tijmenstor commented Sep 16, 2024

MPyL inherently deletes and deploys Jobs in K8s because they modify immutable fields. To ensure same behavior across ArgoCD implementations, we added this annotation.

@tijmenstor tijmenstor changed the title fix: Force ArgoCD to replace s when syncing fix: Force ArgoCD to replace Jobs when syncing Sep 16, 2024
Copy link

Code Coverage

Package Line Rate Health
src.mpyl 93%
src.mpyl.artifacts 60%
src.mpyl.cli 61%
src.mpyl.projects 95%
src.mpyl.reporting 100%
src.mpyl.reporting.formatting 99%
src.mpyl.stages 63%
src.mpyl.steps 88%
src.mpyl.steps.build 82%
src.mpyl.steps.deploy 73%
src.mpyl.steps.deploy.bpm 69%
src.mpyl.steps.deploy.k8s 81%
src.mpyl.steps.deploy.k8s.resources 97%
src.mpyl.steps.postdeploy 82%
src.mpyl.steps.test 93%
src.mpyl.utilities 100%
src.mpyl.utilities.bpm 78%
src.mpyl.utilities.dagster 71%
src.mpyl.utilities.github 74%
src.mpyl.utilities.helm 100%
src.mpyl.utilities.http_client 95%
src.mpyl.utilities.jenkins 69%
src.mpyl.utilities.junit 97%
src.mpyl.utilities.logging 78%
src.mpyl.utilities.pyaml_env 100%
src.mpyl.utilities.repo 66%
src.mpyl.utilities.sbt 96%
src.mpyl.utilities.subprocess 76%
src.mpyl.utilities.yaml 100%
Summary 81% (3011 / 3700)

Minimum allowed line rate is 79%

Copy link

New release 481.4244 deployed at Test Pypi.
Install with

pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple mpyl==481.4244

Copy link
Contributor

@ptab ptab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we should make these annotations configurable per-project, but for now I'm OK with this as it solves an immediate issue.

@tijmenstor tijmenstor merged commit 94f223e into main Sep 16, 2024
7 checks passed
@tijmenstor tijmenstor deleted the fix/argo-force-job-replace branch September 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants