Feature/bpmn 386 remove docker from bpm deploy #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
|
New release |
Jorg88
requested changes
Aug 2, 2024
| bpm_file_path = config.deployment_path.bpm_diagram_folder_path | ||
|
|
||
| for file_name in ( | ||
| [fn for fn in os.listdir(bpm_file_path) if fn.endswith(".bpmn")] |
There was a problem hiding this comment.
This seems a bit hacky? Can't we configure in the project.yml which files to deploy?
There was a problem hiding this comment.
No changes were made to this functionality, this is what is originally in the repository. Since this change is only about removing the dependency on Docker, could we let this slide for now and get back to this in a later PR?
Jorg88
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.