Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default resources for all dagster repos #324

Merged
merged 4 commits into from
Dec 13, 2023
Merged

set default resources for all dagster repos #324

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
166aad0
set default resources for all dagster repos
pietercusters Dec 6, 2023
f0a840f
Fix formatting
kgrunert Dec 7, 2023
a123fff
Fix unittests and failing import
kgrunert Dec 7, 2023
068a674
add release notes
pietercusters Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/mpyl/steps/deploy/k8s/resources/dagster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ def to_user_code_values(
"includeConfigInLaunchedRuns": {"enabled": True},
"name": f"{project.name}{name_suffix}",
"port": 3030,
"resources": {
"requests": {"memory": "256Mi", "cpu": "50m"},
"limits": {"memory": "512Mi", "cpu": "1000m"},
},
},
],
}
Expand Down
4 changes: 2 additions & 2 deletions src/mpyl/utilities/helm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Helper methods for helm deployments
"""

from mpyl.project import Target
from mpyl.steps.models import RunProperties
from ...project import Target
from ...steps.models import RunProperties


def convert_to_helm_release_name(name: str, tag: str) -> str:
Expand Down
7 changes: 7 additions & 0 deletions tests/steps/deploy/dagster/dagster-user-deployments/values_with_global_service_account.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,10 @@ deployments:
enabled: true
name: example-dagster-user-code-pr-1234
port: 3030
resources:
requests:
memory: 256Mi
cpu: 50m
limits:
memory: 512Mi
cpu: 1000m
7 changes: 7 additions & 0 deletions tests/steps/deploy/dagster/dagster-user-deployments/values_with_target_prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,10 @@ deployments:
enabled: true
name: example-dagster-user-code
port: 3030
resources:
requests:
memory: 256Mi
cpu: 50m
limits:
memory: 512Mi
cpu: 1000m
7 changes: 7 additions & 0 deletions .../steps/deploy/dagster/dagster-user-deployments/values_without_global_service_account.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,10 @@ deployments:
enabled: true
name: example-dagster-user-code-pr-1234
port: 3030
resources:
requests:
memory: 256Mi
cpu: 50m
limits:
memory: 512Mi
cpu: 1000m