(fix): Rework shell script for odh release to work with new get_all_m…

…anifests.sh changes (opendatahub-io#1530)
VaishnaviHire · Jan 21, 2025 · 6c7d74b · 6c7d74b
1 parent 94ac12c
commit 6c7d74b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/scripts/get-release-branches.js b/.github/scripts/get-release-branches.js
@@ -34,7 +34,7 @@ module.exports = ({ github, core }) => {
                             idx = splitArr.indexOf("tree")
                         }
                         const branchName = splitArr.slice(idx + 1).join("/")
-                        if (componentName.trim() === "notebook-controller") {
+                        if (componentName.trim() === "workbenches/notebook-controller") {
                             core.exportVariable("component_spec_odh-notebook-controller".toLowerCase(), branchName);
                             core.exportVariable("component_spec_kf-notebook-controller".toLowerCase(), branchName);
                         } else {

diff --git a/.github/scripts/update-manifests-tags.sh b/.github/scripts/update-manifests-tags.sh
@@ -3,7 +3,7 @@
 set -euo pipefail
 
 update_tags(){
-    sed  -i -r "/\"$1\"/s|([^:]*):([^:]*):[^:]*:(.*)|\1:\2:$2:\3|" get_all_manifests.sh
+    sed -i -r "/\"(.*\/)*$1\"/s|([^:]*):([^:]*):[^:]*:(.*)|\1:\2:$2:\3|" get_all_manifests.sh
 }
 
 prefix=component_spec_
@@ -12,6 +12,6 @@ echo
 env | while IFS="=" read varname value; do
     [[ $varname =~ "${prefix}" ]] || continue
     component=${varname#${prefix}}
-    component=${component/_/-}
-    update_tags $component $value
+    component=${component//_/-}
+    update_tags $(basename $component) $value
 done