Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Updated update profile form UI and removed facebook link from frontend successfully Issue 475 #480

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 22, 2024

Pull Request Resolves [#475 ]

Title: Updated update profile form UI and removed facebook link from frontend successfully.

Description

  1. In backend, I removed the facebook link from prisma, controller and routes because facebook is not that important also the form is taking big space and will not look nice in mobile.
  2. In frontend, with the help of model I achieved the beautiful form/model for update profile by the user.

Related Issues

Fixes #475

Changes Made

New feature: Updated update profile form UI and removed facebook link from frontend.

Screenshots

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:30pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 22, 2024

@VaibhavArora314 you are right ! The facebook is not looking nice and also it is not that important as of other social links 👍

@VaibhavArora314
Copy link
Owner

I am keeping this level 1 @MeetDOD, as Facebook link removal was not part of this issue and was part of your previous pull request.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 23, 2024

I am keeping this level 1 @MeetDOD, as Facebook link removal was not part of this issue and was part of your previous pull request.

So, if I put back the facebook link then it will be level 2 🤔

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 23, 2024

@VaibhavArora314 just see the styling efforts done with the Model I hope you understand rest I will leave it to you I will not say anything about it 🙏

@VaibhavArora314
Copy link
Owner

I am keeping this level 1 @MeetDOD, as Facebook link removal was not part of this issue and was part of your previous pull request.

So, if I put back the facebook link then it will be level 2 🤔

Nah, this issue was supposed to be level1 and Facebook link removal was not part of this that's why i said that I am marking this as level 1

@akbatra567 akbatra567 merged commit 3236ad7 into VaibhavArora314:main Jul 23, 2024
4 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 23, 2024

I am keeping this level 1 @MeetDOD, as Facebook link removal was not part of this issue and was part of your previous pull request.

So, if I put back the facebook link then it will be level 2 🤔

Nah, this issue was supposed to be level1 and Facebook link removal was not part of this that's why i said that I am marking this as level 1

Ok let's leave the facebook social link part aside beside that I created a Model and applied style to it, you can consider that and give level 2 if possible 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Styling the update profile form
4 participants