[Bug]: Filter by tag is not working as intended

[Parth18Shah]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Currently, adding a tag as a search filter is filtering posts by that tag as a keyword within the entire data. Instead, it should filter posts based solely on the tags assigned to them.

Expected behavior

Added tag will filter the posts with that tag assigned to it.

Add ScreenShots

No response

On which device are you experiencing this bug?

Windows

Record

• I have read the Contributing Guidelines
• I'm a GSSOC'24 contributor
• I have starred the repository

[github-actions]

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

[VaibhavArora314]

an API request is sent with tags in the usePosts hook which filters posts with at least one of the passed tags. I think this is the logic and keyword searching is done for the search text written by the user. if I am wrong, please correct me.

[Parth18Shah]

Yes you're right but shouldn't we just search the keyword in the tags associated to the posts instead of a search across all of its details.

[VaibhavArora314]

Yes you're right but shouldn't we just search the keyword in the tags associated to the posts instead of a search across all of its details.

we can search the text in tags as well with the description and the title, just modify the Prisma query for this
don't remove the filter option by tags

[Parth18Shah]

Hey there, I believe that someone has fixed the bug I tried to describe above. Now, the filter by tags works as intended, filtering by tags associated with the posts and nothing else (name, description). So you could check and test to see if it still exists, and if it doesn't, then you could close it.

[VaibhavArora314]

Hey there, I believe that someone has fixed the bug I tried to describe above. Now, the filter by tags works as intended, filtering by tags associated with the posts and nothing else (name, description). So you could check and test to see if it still exists, and if it doesn't, then you could close it.

you can work on this if you want since another bug is present now. the tags are shown incorrectly in options

[Parth18Shah]

Sure, I can do it. Thanks. Could you confirm the tag filter inputted by you to get these results?

[VaibhavArora314]

Sure, I can do it. Thanks. Could you confirm the tag filter inputted by you to get these results?

actually, that allPosts.addTag was already present by default

[Parth18Shah]

What does it mean? It doesn't make sense to be displayed, right?

[VaibhavArora314]

What does it mean? It doesn't make sense to be displayed, right?

yes, that's the issue. we need to remove it and if possible below selected tags in filter we can show some options for users to select tags from

[Parth18Shah]

Can't we modify the placeholder to show some sample keywords that the users could use to filter by tag?

[VaibhavArora314]

Can't we modify the placeholder to show some sample keywords that the users could use to filter by tag?

yes, you can see how we are getting some of these on the home page and reuse that logic

[Parth18Shah]

Got it

[Parth18Shah]

I noticed that some bugs discussed here have already been resolved. So, I will be working on the following things over here:

• Mainly add a few tags in the placeholder as an example
• Modify the code layout not to show the previous and next button if no results are found
• Modify the styling of the text on the posts displayed to avoid the dark blue/white strip behind the text

Could you please confirm if you want to keep the filter by tags case insensitive? Currently, we are storing the input tags in lowercase, which will skip over the posts that contain the same tags but with different characters capitalized. For example, a post with the tag 'Form' won't show currently if we filter by 'form' or even 'Form' tag.

[VaibhavArora314]

I noticed that some bugs discussed here have already been resolved. So, I will be working on the following things over here:

• Mainly add a few tags in the placeholder as an example
• Modify the code layout not to show the previous and next button if no results are found
• Modify the styling of the text on the posts displayed to avoid the dark blue/white strip behind the text

Could you please confirm if you want to keep the filter by tags case insensitive? Currently, we are storing the input tags in lowercase, which will skip over the posts that contain the same tags but with different characters capitalized. For example, a post with the tag 'Form' won't show currently if we filter by 'form' or even 'Form' tag.

Sure go ahead. Just one question, which dark blue/white strip?

[Parth18Shah]

notice that there is a background strip behind the text 'Modal' and 'modal' that goes across the width .. although they aren't very visible, they aren't needed, and once you notice them, they seem to be distracting.

Could you please comment on the case insensitive part for the filtering?

[VaibhavArora314]

notice that there is a background strip behind the text 'Modal' and 'modal' that goes across the width .. although they aren't very visible, they aren't needed, and once you notice them, they seem to be distracting.

Could you please comment on the case insensitive part for the filtering?

The filtering should be case insensitive and for the background, you can remove the strips.

[Parth18Shah]

Understood, thanks for your response. Sorry for the delay in my response.

[github-actions]

Hello @Parth18Shah! Your issue #341 has been closed. Thank you for your contribution!