-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: workflow の冗長な記述を削除 #1286
Merged
Merged
整理: workflow の冗長な記述を削除 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Hiroshiba
reviewed
May 27, 2024
Hiroshiba
reviewed
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflowの書式にこだわりだしてくるといよいよフォーマッター導入の機運ですね!
いつも適当にPrettierでフォーマットしていますが、ステップごとに改行をいれるかどうかとかは設定になかった気がします。
なにか良いフォーマッターがあれば・・・。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
workflow の冗長な記述の削除するリファクタリングを提案します。
削除対象となった記述と理由は以下である:
run: |
: bash 最小化の方向性であるため、複数行を前提とする必要無しid: setup-python
: 参照されない ID は不要branches:
: 全PR受け入れなら条件文は冗長on: [ ... ]
: テストは全条件で実行されるため、条件文を想定してxxx:
記法とする必要無しshell: bash
: グローバルのdefault
と同一設定であり冗長python -m pip
: 多くの箇所でpip
を採用しており動作も同じため冗長関連 Issue
無し