Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: EngineManifest 系モジュールを統合 #1255

Merged
merged 2 commits into from
May 22, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 17, 2024

内容

内容が少なくなった EngineManifest 系モジュールを統合してリファクタリングすることを提案します。

関連 Issue

ref #1230 (review)

@tarepan tarepan requested a review from a team as a code owner May 17, 2024 17:38
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 17, 2024 17:38
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit d9dd729 into VOICEVOX:master May 22, 2024
4 checks passed
@tarepan tarepan deleted the refactor/manifest_module branch May 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants