整理: manage_library
feature flag を削除
#1254
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: 役割を終えた
manage_library
feature flag を削除するリファクタリングを提案します。現在の
engine_manifest.json
はmanage_library.value
がTrue
である。かつてはこれが
False
であり、generate_app()
とルーター内でこの値を参照する feature flag により実装を無効化していた。ゆえに現在、この feature flag は役割を終えている。不要な feature flag は削除が望ましい。
このような背景から、
manage_library
feature flag を削除するリファクタリングを提案します。関連 Issue
無し