-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
追加: 依存パッケージ脆弱性診断を導入し現パッケージに適用 #1151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Apr 7, 2024
@Hiroshiba |
Hiroshiba
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
なるほど、依存してるパッケージのバージョンが良くない時もあるんですね。
直接依存してるわけではないパッケージの更新方法の案内もあっても良いかもと思いました。
まあ、CIが入ったら…!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: 依存パッケージ脆弱性診断を追加し、現時点での脆弱性を修正した。
依存パッケージ脆弱性診断は定期的に行う必要があり、そのためには ENGINE として定型の脆弱性診断が必要である。
よって
safety
を導入し、その利用法案内をCONTRIBUTING.md
へ追記した。これにより今後のコントリビュータが手動で容易に脆弱性診断をおこなえる。
また、この依存パッケージ脆弱性診断により、現時点での脆弱性を修正した。
関連 Issue
part of #728
定期診断 CI は #1152 にて導入予定