Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
複数エンジン対応:複数の辞書に対する操作を追加 #980
複数エンジン対応:複数の辞書に対する操作を追加 #980
Changes from 8 commits
3998092
232cf5a
2f0b759
01b2db0
823e040
c75964a
995f21c
3ff9977
ee86f15
8013ff5
40236e4
678c08e
eb6161b
2454f59
af8c1ee
f6eb36c
761c9c8
296c9b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このコメントは、ADD_WARDをしたあとにSYNCすると、という意味ですよね。
ADD_WARDはただ単語を追加する処理でSYNCとは独立しているため、SYNCを実行した場合のコメントをここに書くと、たぶんSYNCのことを知らない他の開発者の方が混乱すると思います。
このコメントを書くなら、辞書UIでADD_WARDを実行しているところのが適切かもです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYNCをADD_WORDにも書く、でも解決できそうな感じがしました。