Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: アクセント句単位でまとめてモーラ設定値を変更できるようにした #623
feat: アクセント句単位でまとめてモーラ設定値を変更できるようにした #623
Changes from 3 commits
c3476b7
d975a8c
e3793b7
958a25b
ef2a7de
c258b0b
50cdb2b
7322cdd
28b9b0b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど!!
この実装だと、コマンドが複数登録されてしまうので、ctrl+zで一気にやり直すことができなそうです。
一括変更する新しいCOMMAND関数を作ってそちらで修正するのが、一番良い解決だと思います。
が、それはCOMMANDの実装などを把握する必要があって結構大変かもしれません。
実装が難しそうであれば、一旦experimental機能にする手もありそうです。
お手数おかけしちゃいますが、どちらか実装をお願いしたいです・・・!
(個人的には、まあ適当なCOMMANDをコピペして、この処理を移動すれば実装完了な気がしているので、実装しちゃっても良いのかなとちょっと思っています。)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COMMAND内部でaccentPhraseを取得してるところが見当たらなかったのですが、COMMANDの引数としてaccentPhraseを渡しても問題ないでしょうか?
ここでの作法がよくわからずどう実装してよいか迷っています
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accentPhraseは渡しても問題ないはずです!
COMMANDに渡して良い値は、いまのところ制約がないと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とりあえずコピペしてCOMMAND化しました