複数選択：話者変更するとAudioQueryのテキストがAudioCellのテキストと一致しなくなるバグを修正 #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ふと気になって試してました、これUndoが一括でできなくなってますね。Draft行き。 |
|
なんとかしました。 |
Merged
Hiroshiba
reviewed
Dec 4, 2023
エラーハンドリングで悩んでます、例えば複数回エラーが起きたらどんなエラーを投げるべきかとか |
とりあえず失敗したaudioKeyをエラー文に組み込んでthrow、とかで良いかなと！！（変更前もそうですし） あとはまあ…失敗したのはAudioQueryをundefinedにする、とか…？（ちゃんと考えれてないです） |
|
良い感じになったと思います。 |
Hiroshiba
reviewed
Dec 5, 2023
|
プリセット周りを足しました。 |
Hiroshiba
reviewed
Dec 13, 2023
src/store/audio.ts
Outdated
Comment on lines
2046
to
2051
| if (shouldApplyPreset) { | ||
| audioStore.mutations.SET_AUDIO_PRESET_KEY(state, { | ||
| audioKey, | ||
| presetKey: nextPresetKey, | ||
| }); | ||
| } |
There was a problem hiding this comment.
セットする時はshouldApplyPresetのチェックいらないかもです！
MULTI化する前のCOMMAND_CHANGE_VOICEのコードに合わせればいいはずかなと
https://github.com/VOICEVOX/voicevox/pull/1228/files#diff-b86b438c7928773aac473007988ffb602afc8278b8e2226ce784442befb46b0dR2096
Hiroshiba
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通りです。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）