Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

モーラごとの調整結果保持のテストを追加 #1646

Conversation

Hiroshiba
Copy link
Member

内容

のテストを追加しました。

あとコメントをちょっと調整して読みやすくしてみたり、適切にprivate関数化したりしました。

関連 Issue

#1354

その他

weweweok and others added 30 commits October 19, 2023 10:52
@Hiroshiba Hiroshiba requested a review from a team as a code owner November 10, 2023 00:48
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team November 10, 2023 00:48
Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weweweok コメントの変更を行っているのですが、何か認識が違うところとかあったらご指摘いただけると・・・! 🙇

@weweweok
Copy link
Contributor

特に認識が異なる部分はないと思います。

@Hiroshiba
Copy link
Member Author

@weweweok 確認ありがとうございます!!

問題ないと思うのでマージじます!!

@Hiroshiba Hiroshiba merged commit aee7d1f into VOICEVOX:main Nov 10, 2023
@Hiroshiba Hiroshiba deleted the アクセント句内の差分のプルリクエストをいろいろ変えてみた branch November 10, 2023 03:43
@Hiroshiba Hiroshiba removed the request for review from y-chan November 10, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants