ショートカットキーを初期値に戻す際に、衝突チェックを行うようにしました #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Oct 24, 2023
There was a problem hiding this comment.
LGTM！！！
コメントも適切ですし、コードも適切で、かつ挙動も自然でものすごい分かりやすかったです！！
listエラーが出ているのでコードフォーマットしていただけると！
https://github.com/VOICEVOX/voicevox#%E5%9E%8B%E3%83%81%E3%82%A7%E3%83%83%E3%82%AF
@thiramisu 確か別のプルリクエストでこの辺りのコード触られてたと思うのでお知らせメンションです！
|
@yuriko0505 ちょっと難度が上がりますが、webフロント（というよりもVuejsですが）の知見が得られるこちらのissueとかご興味あれば、ぜひ！！
|
|
マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ショートカットキーを「初期値に戻す」とした時、他の action と衝突する場合はショートカットキー設定のダイアログを出すようにしました。
settingが undefined の場合は、従来通り何の処理も行わないようにしています。関連 Issue
ref #566
スクリーンショット・動画など
特になし
その他
特になし