-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
複数選択:キャラクターを変更できるように #1546
Merged
Hiroshiba
merged 9 commits into
VOICEVOX:main
from
sevenc-nanashi:add/multi-character-change
Sep 19, 2023
+187
−106
Merged
複数選択:キャラクターを変更できるように #1546
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e9e8434
Add: 複数選択でキャラクターを変更できるように
sevenc-nanashi 1753add
Add: テストを追加
sevenc-nanashi 7c021b8
Change: common.ts -> utils.ts
sevenc-nanashi b82162b
Change: CHANGE_VOICES -> MULTI_CHANGE_VOICE
sevenc-nanashi b651e6e
Change: audioKeysInitializingSpeaker -> audioKeysWithInitializingSpeaker
sevenc-nanashi 4ff5be5
Change: SET_AUDIOS_VOICE -> SET_AUDIO_VOICE
sevenc-nanashi 23e58f4
Revert: 不要な変更をRevert
sevenc-nanashi 8ddcf5b
Merge: main -> add/multi-character-change
sevenc-nanashi d0166ea
Fix: Vueの型エラーを修正
sevenc-nanashi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { Page } from "@playwright/test"; | ||
|
||
export async function addAudioCells(page: Page, count: number) { | ||
for (let i = 0; i < count; i++) { | ||
await page.getByRole("button", { name: "テキストを追加" }).click(); | ||
await page.waitForTimeout(100); | ||
} | ||
} | ||
|
||
export const ctrlLike = process.platform === "darwin" ? "Meta" : "Control"; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ2回出てきてるので、AudioKeyを引数にしたGETTER関数
isInitializingSpeaker
にしてあげてもいいかも。まあシンプルなのでそのままでもいいかも。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
シンプルなのでそのままで良いと思います