Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ブラウザ版のmacOS判定がおかしかったっぽいので直します。
関連 Issue
その他
electronだとprocessが必ず存在しているけど、
process.platformはレンダラー側にはなさそう。ここが以前の判定だと間違ってた。
chrome系は実験的機能だけど
navigator.userAgentDataが便利そう。navigator.platformは非推奨機能だけどどのブラウザも実装しっぱなしなので一番これが利便性高そう。ユーザーエージェントで判断するところまではだいたいのブラウザで来ない気がするけど、スマホをブラウザとかだと違うかもなので必ず値を返すように置いてます。
もし将来的にユーザーエージェントをしっかりと判定に使うようにするのであれば
UAParser.jsとかのライブラリを使うと良さそう。