Fix: vue-devtools が起動しない問題を修正 #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shm11C3
commented
Jul 1, 2023
| @@ -991,9 +991,9 @@ app.once("will-finish-launching", () => { | |||
| }); | |||
|
|
|||
| app.on("ready", async () => { | |||
| if (isDevelopment) { | |||
| if (isDevelopment && !isTest) { | |||
There was a problem hiding this comment.
テスト実行時でも isDevelopment === true になるようで、タイムアウトになってCIが通らなくなっていました。
E2Eテストにvue-devtools のインストールは必要なさそうだったので条件を追加しましたが、なにか問題があれば教えていただきたいです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要
npm run electron:serve実行時に以下のようなエラーを吐いて vue-devtools が起動しなかったため修正しました。[error] Vue Devtools failed to install: Error: Invalid header: Does not start with Cr24原因
electron-devtools-installerで設定されていたextension idが古く参照できなくなっていたたため参考：MarshallOfSound/electron-devtools-installer#222 (comment)
修正内容
src/background.tsのVUEJS3_DEVTOOLSをVUEJS_DEVTOOLSに変更スクリーンショット
修正前
修正後