Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actionsでshell: bashを毎回書かなくても良いようにする #1338

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jun 17, 2023

内容

shell: bashを不要にできるオプションがあったので指定してみました。
とりあえずubuntu以外でのOSで実行していたworkflowにのみ付けています。
https://docs.github.com/ja/actions/using-workflows/workflow-syntax-for-github-actions#defaultsrun

ついでにディスク容量の心配がなくなっていたのでdf -hを消してみました。

2023/06/19 14:30追記
shell: bashを付けるか付けないかでubuntu/mac上の挙動が変わり、かつ付けたときのほうが良さそうなので全部に付けました。

  run:
    shell: bash
@Hiroshiba Hiroshiba requested a review from a team as a code owner June 17, 2023 20:45
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team June 17, 2023 20:45
@@ -8,7 +8,7 @@ on:
workflow_dispatch:

jobs:
build:
typos:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そういえばここだけずっと違っていたのが気になったのでついでに。

@Hiroshiba
Copy link
Member Author

Hiroshiba commented Jun 18, 2023

releaseの作成も試してみます。
https://github.com/VOICEVOX/voicevox/releases/tag/0.15.0-checkshellbash.0 にできるはずです。

2023/06/18 21:58追記 できてそうでした!

@Hiroshiba
Copy link
Member Author

問題ないと思うのでマージします!

@Hiroshiba Hiroshiba merged commit 422f7b9 into main Jun 19, 2023
@Hiroshiba Hiroshiba deleted the default-shell-bash branch June 19, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant