エンジン追加の際にセキュリティ上の驚異を紹介し、信頼できるエンジンかを問う #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 tasks
sevenc-nanashi
approved these changes
Dec 15, 2022
| $q.dialog({ | ||
| title: "エンジン追加の確認", | ||
| message: | ||
| "この操作はコンピュータに損害を与える可能性があります。エンジンの配布元が信頼できない場合は追加しないでください。", |
There was a problem hiding this comment.
Suggested change
| "この操作はコンピュータに損害を与える可能性があります。エンジンの配布元が信頼できない場合は追加しないでください。", | |
| "この操作はコンピュータに損害を与える可能性があります！エンジンの配布元が信頼できない場合は追加しないでください！", |
ちょっと強気にしてみるのもありかも…？
There was a problem hiding this comment.
面白いですね！
語調に一貫性があったほうが信頼感が増すと思うので、ここだけ感嘆文にするということは避けた方が良いかなと思いました！（とりあえず今回は）
|
レビューありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
セキュリティ上の驚異を紹介し、信頼できるエンジンかを問うというタスクです。関連 Issue
スクリーンショット・動画など
その他
文面の方針として次のことに意識しました。