Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r9y9 0.3.0 #16

Merged
merged 33 commits into from
Feb 2, 2023
Merged

Merge r9y9 0.3.0 #16

merged 33 commits into from
Feb 2, 2023

Conversation

r9y9 and others added 30 commits January 28, 2022 23:46
Not sure about the exact root cause, but the error messages suggested
that there's issues with setuptools/pip. I can confirm we can fix the
issue by changing the build-time setuptools requirement to <v60.0.

At least v59.8.0 should work.
https://github.com/pypa/setuptools/releases/tag/v59.8.0
Update binary dependencies (hts_engine_API/open_jtalk)
Co-authored-by: Ryuichi Yamamoto <zryuichi@gmail.com>
Co-authored-by: Ryuichi Yamamoto <zryuichi@gmail.com>
Co-authored-by: Ryuichi Yamamoto <zryuichi@gmail.com>
@aoirint
Copy link
Member Author

aoirint commented Feb 2, 2023

Windows 10、Python 3.10.9でpytestが成功することを確認したのでReady for reviewにします。

@aoirint aoirint marked this pull request as ready for review February 2, 2023 01:14
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

marineも使えるようになってインターフェイスちょい変わった、って感じですかね…!

@Hiroshiba
Copy link
Member

特に懸念事項もない気がするのでマージしちゃいます!
@takana-v @Yosshi999 一応共有まで…!

@Hiroshiba Hiroshiba merged commit 827a3fc into VOICEVOX:master Feb 2, 2023
@aoirint aoirint deleted the merge-r9y9-0.3.0 branch February 2, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants