Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1891 ✨ Add object filter for EnkelvoudigInformatieObject resource #151

Closed
wants to merge 3 commits into from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Nov 16, 2021

Issue: VNG-Realisatie/gemma-zaken#1891 (the Documenten API part)

Changes:

  • Add an object filter on EnkelvoudigInformatieObject resource, to allow filtering on related objecten (zaken/besluiten)
  • Pin spectral dependency in CI to 5.9.2

@stevenbal stevenbal marked this pull request as draft November 16, 2021 12:48
@codecov-commenter
Copy link

Codecov Report

Merging #151 (6c6ce71) into master (870b7b4) will increase coverage by 0.03%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   91.75%   91.79%   +0.03%     
==========================================
  Files         137      137              
  Lines        3577     3618      +41     
  Branches      160      163       +3     
==========================================
+ Hits         3282     3321      +39     
- Misses        263      264       +1     
- Partials       32       33       +1     
Impacted Files Coverage Δ
src/drc/api/filters.py 94.59% <87.50%> (-5.41%) ⬇️
.../drc/api/tests/test_enkelvoudiginformatieobject.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870b7b4...6c6ce71. Read the comment docs.

@stevenbal stevenbal marked this pull request as ready for review November 16, 2021 13:16
@stevenbal stevenbal changed the title Feature/1891 eio object filter #1891 ✨ Add object filter for EnkelvoudigInformatieObject resource Nov 16, 2021
Copy link
Contributor

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dank, wat mij betreft in orde. Wat mij betreft aan @michielverhoef voor de definitieve bevestiging dat deze aanpassing meegenomen mag worden in de volgende versie van het DRC

@joeribekker
Copy link
Contributor

I don't see any reason why this was closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants