Special replacement patterns fix (#48)

* Special replacement patterns fix Specifying a function as a parameter do not apply special replacement patterns: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter Signed-off-by: Vitaliy Khamin <vitaliykhamin@gmail.com> * Stream special replacement pattern test Signed-off-by: Vitaliy Khamin <vitaliykhamin@gmail.com>
VFK · Jun 17, 2016 · 5421df7 · 5421df7
1 parent 8591aa4
commit 5421df7
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 1 deletion.
diff --git a/lib/parser.js b/lib/parser.js
@@ -32,7 +32,9 @@ Parser.prototype._transform = function (chunk, enc, done) {
     var matches = common.regexMatchAll(content, regex);
     matches.forEach(function (match) {
         var block = new Block(this.config, this.file, match);
-        content = content.replace(block.replacement, block.compile(this.tasks));
+        content = content.replace(block.replacement, function () {
+            return block.compile(this.tasks)
+        }.bind(this));
     }.bind(this));
 
     done(null, content);

diff --git a/test/buffer.js b/test/buffer.js
@@ -70,6 +70,9 @@ describe('Buffer mode', function () {
             'stream-simple': stringToStream('Stream simple replacement').pipe(source('fake-vinyl.txt')),
             'stream-advanced': {
                 src:  stringToStream('Stream advanced replacement').pipe(source('fake-vinyl.txt'))
+            },
+            'stream-special': {
+                src: stringToStream('Stream $$ special replacement pattern').pipe(source('fake-vinyl.txt'))
             }
         });
 

diff --git a/test/expected.html b/test/expected.html
@@ -38,5 +38,7 @@
 Stream simple replacement
 
 Stream advanced replacement
+
+Stream $$ special replacement pattern
 </body>
 </html>
diff --git a/test/fixture.html b/test/fixture.html
@@ -58,5 +58,8 @@
 
 <!-- build:stream-advanced -->
 <!-- endbuild -->
+
+<!-- build:stream-special -->
+<!-- endbuild -->
 </body>
 </html>
diff --git a/test/stream.js b/test/stream.js
@@ -76,6 +76,9 @@ describe('Stream mode', function () {
             'stream-simple': stringToStream('Stream simple replacement').pipe(source('fake-vinyl.txt')),
             'stream-advanced': {
                 src:  stringToStream('Stream advanced replacement').pipe(source('fake-vinyl.txt'))
+            },
+            'stream-special': {
+                src: stringToStream('Stream $$ special replacement pattern').pipe(source('fake-vinyl.txt'))
             }
         });