Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noobhour #508

Closed
NicolasNeubauer opened this issue Sep 15, 2018 · 19 comments
Closed

noobhour #508

NicolasNeubauer opened this issue Sep 15, 2018 · 19 comments
Labels

Comments

@NicolasNeubauer
Copy link

NicolasNeubauer commented Sep 15, 2018

Hi,

I created a plugin, here's the content of my manifest. I'm not 100% sure if the parts in the docs about adding the repo and the manifest mean that I should do that and submit a PR, or if that's done by the community members. From a first look, it seems the latter, but please let me know if I should submit the PR. Thanks!
Nic

{
"name": "noobhour modules",
"author": "Nicolas Neubauer",
"license": "BSD-3-Clause",
"manualUrl": "https://github.com/NicolasNeubauer/noobhour_modules/blob/master/README.md",
"pluginUrl": "https://github.com/NicolasNeubauer/noobhour_modules",
"authorEmail": "noobhourmusic@gmail.com",
"latestVersion": "0.6.0",
"status": "available"
}

@cschol cschol added the plugin label Sep 15, 2018
@cschol
Copy link
Collaborator

cschol commented Sep 15, 2018

You don't need to submit a PR. I'll take it from here and let you know if I need anything else. Thank you for creating and submitting a module!

@cschol
Copy link
Collaborator

cschol commented Sep 15, 2018

This looks good. I added the module to the community manifest. When Andrew builds the next round of plugins your module will be included in the distribution and be available via the Plugin Manager. This takes usually a few days. You don't need to do anything else, except let us know in this issue when a new version becomes available. We will reopen the issue and process the new module information.

@AndrewBelt
Copy link
Member

Updated build

@NicolasNeubauer
Copy link
Author

Hi,

a new version is available, it fixes two issues and introduces a new module, CustomScale.
Please find the manifest below.
Thanks!
Nic

{
"name": "noobhour modules",
"author": "Nicolas Neubauer",
"license": "BSD-3-Clause",
"manualUrl": "https://github.com/NicolasNeubauer/noobhour_modules/blob/master/README.md",
"sourceUrl": "https://github.com/NicolasNeubauer/noobhour_modules",
"authorEmail": "noobhourmusic@gmail.com",
"latestVersion": "0.6.1",
"status": "available"
}

@NicolasNeubauer
Copy link
Author

Btw, where would I define the tags for modules? Haven't found anything, so maybe here? If so:

  • Baseliner is an attenuator and a switch
  • CustomScale is a quantizer

@cschol cschol reopened this Sep 21, 2018
@cschol
Copy link
Collaborator

cschol commented Sep 21, 2018

It's one of the arguments of the Model definition, usually at the end of the module source code file.

@NicolasNeubauer
Copy link
Author

Ah! Thanks - repo's updated.

@AndrewBelt
Copy link
Member

Updated build

@NicolasNeubauer
Copy link
Author

Hi,

there's a new version available under https://github.com/NicolasNeubauer/noobhour_modules/tree/0.6.2
Can you add it please? Thanks!

  • introducing Bsl1r
  • Customscaler:
    • renamed from CustomScale
    • significant performance improvements
    • new layout
    • randomize functionality overhauled (randomizes selected tones)
  • Baseliner:
    • daisy-chaining inputs and outputs

{
"name": "noobhour modules",
"author": "Nicolas Neubauer",
"license": "BSD-3-Clause",
"manualUrl": "https://github.com/NicolasNeubauer/noobhour_modules/blob/0.6.2/README.md",
"sourceUrl": "https://github.com/NicolasNeubauer/noobhour_modules",
"authorEmail": "noobhourmusic@gmail.com",
"latestVersion": "0.6.2",
"status": "available"
}

@NicolasNeubauer
Copy link
Author

Hi, found a bug playing around, re-made the 0.6.2 release, could you rebuild please? Correct commit is c3fae38
Thanks & sorry for the hassle

cschol added a commit that referenced this issue Sep 30, 2018
@AndrewBelt
Copy link
Member

Updated build

@NicolasNeubauer
Copy link
Author

Hi,

new version 1.0.0 available under https://github.com/NicolasNeubauer/noobhour_modules/releases/tag/1.0.0 (commit
3d4ac0b4f1b60c6911bc85c8f09fcf530b1cba96)

Thanks
Nic

@AndrewBelt AndrewBelt reopened this Jun 16, 2019
@cschol
Copy link
Collaborator

cschol commented Jun 16, 2019

Minor plugin.json issues: NicolasNeubauer/noobhour_modules#6

@NicolasNeubauer
Copy link
Author

new version 1.0.2 available under https://github.com/NicolasNeubauer/noobhour_modules/releases/tag/1.0.2 (commit
1e1a908466b518261b36cf56eca54fd1365b2557)

@NicolasNeubauer
Copy link
Author

new version available 1.0.3 under
https://github.com/NicolasNeubauer/noobhour_modules/releases/tag/1.0.3
(commit 48f11951a147a49453e7c5463e56dd2823a679e1)

@cschol cschol reopened this Jul 1, 2019
@NicolasNeubauer
Copy link
Author

is it possible to retract this release? nothing wrong with it, just that I'd follow up with another one very soon as I've created another bugfix

@cschol
Copy link
Collaborator

cschol commented Jul 3, 2019

Sure. Let us know when a new version is available.

@cschol cschol closed this as completed Jul 3, 2019
@NicolasNeubauer
Copy link
Author

new version available 1.0.3 under
https://github.com/NicolasNeubauer/noobhour_modules/releases/tag/1.0.3
commit c5bac4207e3fff4a2cff761523d2d7ad95de75bb

bugfixes and new module: Normaliser

@NicolasNeubauer
Copy link
Author

new version available 2.0.0 under
https://github.com/NicolasNeubauer/noobhour_modules/releases/tag/2.0.0
commit fd172d0cd62ee6ca5612950ba22de0cca622d1ef

Migration to v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants