Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purple screen fix with physical camera #349

Merged
merged 6 commits into from
Nov 26, 2023

Conversation

fire
Copy link
Member

@fire fire commented Nov 26, 2023

Thanks Saracen!

Attempts to fix the purple screen bug when in flat mode. Has not yet been tested in VR.

Has been tested in both vr and desktop. Trying to test from Github actions now.

Test Plan

  1. From the project manager click run will run in vr mode
  2. From the editor play menu this will run in the desktop mode

@fire
Copy link
Member Author

fire commented Nov 26, 2023

Some screenshots

Desert light in VR

Desert light in Desktop

@fire
Copy link
Member Author

fire commented Nov 26, 2023

Testing the github action build shows that the player gets stuck in the ground, but the build works in the editor, and it is a improvement over a purple screen on the desktop because it shows the view.

There are other bugs I found:

  1. rendering is slow 11ms which is 3 ms above 8.3ms
  2. sometimes the scene is too dark and you see a black screen, but it's merely too dark.
  3. Desktop fov (like the camera is fisheyed) is wrong
  4. VR looks fine

@fire fire force-pushed the purple-screen-fix-with-physical-camera branch from f800506 to 086a3b7 Compare November 26, 2023 22:46
@fire fire merged commit fdc06b8 into main Nov 26, 2023
@fire fire deleted the purple-screen-fix-with-physical-camera branch November 26, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant