Merge pull request civicrm#28459 from eileenmcnaughton/deprecate

Stop using & deprectate `getSalesTaxTerm`
UshaMakoa · Dec 4, 2023 · 0e4a484 · 0e4a484
2 parents cef269a + 83085da
commit 0e4a484
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CRM/Financial/Form/SalesTaxTrait.php b/CRM/Financial/Form/SalesTaxTrait.php
@@ -18,8 +18,11 @@ trait CRM_Financial_Form_SalesTaxTrait {
 
   /**
    * Assign the sales tax term to the template.
+   *
+   * @deprecated since 5.69 will be removed around 5.80
    */
   public function assignSalesTaxTermToTemplate() {
+    CRM_Core_Error::deprecatedFunctionWarning('assign the setting');
     $this->assign('taxTerm', $this->getSalesTaxTerm());
   }
 
@@ -47,7 +50,7 @@ public function getSalesTaxTerm() {
    */
   public function assignSalesTaxMetadataToTemplate() {
     $this->assignSalesTaxRates();
-    $this->assignSalesTaxTermToTemplate();
+    $this->assign('taxTerm', $this->getSalesTaxTerm());
   }
 
   /**

diff --git a/CRM/Price/Page/Option.php b/CRM/Price/Page/Option.php
@@ -189,7 +189,7 @@ public function browse(): void {
     $this->assign('customOption', $customOption);
     $this->assign('sid', $this->_sid);
     $this->assign('isEvent', $isEvent);
-    $this->assignSalesTaxTermToTemplate();
+    $this->assign('taxTerm', $this->getSalesTaxTerm());
   }
 
   /**